Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qtconsole hangs at exit after update to Tornado 5.0 #275

Closed
ccordoba12 opened this issue Mar 7, 2018 · 2 comments · Fixed by jupyter/jupyter_client#352
Closed

Qtconsole hangs at exit after update to Tornado 5.0 #275

ccordoba12 opened this issue Mar 7, 2018 · 2 comments · Fixed by jupyter/jupyter_client#352

Comments

@ccordoba12
Copy link
Collaborator

ccordoba12 commented Mar 7, 2018

Simply starting qtconsole from a terminal and then closing it makes it hang. You need to press Ctrl+C to interrupt a hanging thread and make it finish.

@minrk, the same thing happens to Spyder. Could you help us with this one? I really don't understand how to fix it.

By the way, jupyter-console doesn't show this behavior. That's why I didn't fill this report in ipykernel.

@minrk
Copy link
Member

minrk commented Mar 8, 2018

@ccordoba12 I believe this is fixed by jupyter/jupyter_client#352 can you test?

@ccordoba12
Copy link
Collaborator Author

On it, thanks!

minrk pushed a commit to jupyter/jupyter_client that referenced this issue Mar 11, 2018
The main issue was failing to schedule `ioloop.stop` in the ioloop thread, which is required when tornado is running on asyncio in order to wake the thread. The result of not doing this is hanging forever when trying to exit, e.g. in QtConsole.

There is further cleanup of threadsafety issues with respect to asyncio and tornado objects.

closes jupyter/qtconsole#275

cc  ccordoba12

Signed-off-by: Min RK <benjaminrk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants