Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python_requires to help pip, and version classifers #57

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Add python_requires to help pip, and version classifers #57

merged 3 commits into from
Mar 18, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jun 11, 2018

Based on the versions tested by .travis.yml, which match the supported CPython versions.

https://en.wikipedia.org/wiki/CPython#Version_history

And here's the pip installs for terminado from PyPI for May 2018:

python_version percent download_count
2.7 41.87% 136,449
3.6 26.07% 84,967
3.5 18.60% 60,618
3.4 13.15% 42,869
3.7 0.27% 876
3.3 0.03% 103
2.6 0.00% 15
3.8 0.00% 1
Total 325,898

Source: pypinfo --start-date 2018-05-01 --end-date 2018-05-31 --percent --markdown terminado pyversion

@hugovk
Copy link
Contributor Author

hugovk commented Jun 11, 2018

The Travis failure is unrelated, latest master is failing in the same way:

https://travis-ci.org/jupyter/terminado/builds/361105398

pyproject.toml Outdated
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in testpath, I don't like using these specific classifiers. They only get outdated and then need to be updated. If we need to specify Python version compatibility, requires-python is the way to do it.

pyproject.toml Outdated
@@ -13,10 +13,15 @@ requires = [
"pywinpty (>=0.5);os_name=='nt'",
"tornado (>=4)",
]
python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take is that this is more trouble than it's worth until we can express it concisely (>=3.4). But I'm open to other opinions.

The field in flit is called requires-python, though: http://flit.readthedocs.io/en/latest/pyproject_toml.html#metadata-section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've removed the x.y classifiers, and corrected this field.

@takluyver
Copy link
Member

Thanks. I'll give other people a chance to opine on the use of the requires-python field here.

@takluyver
Copy link
Member

The test failure on Py 2.7 seems to be reproducible. :-/

@takluyver
Copy link
Member

Close/reopen to rerun tests

@takluyver takluyver closed this Mar 18, 2019
@takluyver takluyver reopened this Mar 18, 2019
@takluyver takluyver merged commit 5104dcb into jupyter:master Mar 18, 2019
@hugovk hugovk deleted the patch-1 branch March 18, 2019 18:23
devmonkey22 added a commit to devmonkey22/terminado that referenced this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants