Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwargs to NamedTermManager.new_named_terminal #70

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

qntnrbns
Copy link
Contributor

@qntnrbns qntnrbns commented Nov 10, 2019

Hi, I am trying to fix this issue jupyterlab/jupyterlab#1366 in jupyterlab so that terminals open in the current working directory.

In order to do this, we need to be able to pass key word arguments to the new_terminal call in new_named_terminal so that the jupyter server can create terminals with different working directories.

def new_named_terminal(self):
name = self._next_available_name()
term = self.new_terminal()
self.log.info("New terminal with automatic name: %s", name)
term.term_name = name
self.terminals[name] = term
self.start_reading(term)
return name, term

@qntnrbns qntnrbns changed the title Addkwargs to NamedTermManager.new_named_terminal Add kwargs to NamedTermManager.new_named_terminal Nov 10, 2019
@blink1073
Copy link
Contributor

Thanks! I tracked down the build failure to an implicit reliance on Ubuntu 14.04 in our tests. Can you please add dist: trusty to the top of .travis.yml to get us un-stuck?

@qntnrbns
Copy link
Contributor Author

@blink1073 thanks for the help! the build seems all good now

@blink1073
Copy link
Contributor

LGTM, thanks!

@blink1073 blink1073 merged commit d14a041 into jupyter:master Nov 12, 2019
@qntnrbns qntnrbns deleted the named-terminal-kwargs branch November 12, 2019 15:13
@qntnrbns
Copy link
Contributor Author

@blink1073 is there a process for getting the version number bumped so that this can go into jupyter?

@blink1073
Copy link
Contributor

Already done! Released as 0.8.3.

@qntnrbns
Copy link
Contributor Author

ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants