Split big index.js file into multiple smaller files #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
yuvipanda
force-pushed
the
split
branch
3 times, most recently
from
8ec783e
to
8bae043
Compare
|
omg is it finally happening?! |
consideRatio
added
maintenance
consideRatio
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Thank you for working this @yuvipanda!!!
LGTM except a few (I think) easy-to-resolve comments!
- Follows the plan laid out in jupyterhub#777 - Only non-trivial move is to cleanup the `_config` call to use the more modern 'fetch' API rather than the older XMLHttpRequest API Fixes jupyterhub#777
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
|
Thanks @consideRatio. I've applied your suggested changes. I think after this gets merged, I'll enable prettier for JS in this repo as well, so that should handle all other formatting inconsistencies. |
consideRatio
reviewed
Oct 9, 2023
|
Wieeee thank you @yuvipanda for taking the time to this!!! ❤️ 🎉 |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 9, 2023
jupyterhub/binderhub#1761 Merge pull request #1761 from yuvipanda/split
yuvipanda
added a commit
to yuvipanda/binderhub
that referenced
this pull request
Oct 9, 2023
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor index.js megafile into mutliple files #777
_configcall touse the more modern 'fetch' API rather than the older
XMLHttpRequest API
Fixes #777
A screen recording of me testing this is available in
#1758