JS: Remove all references to global URL constants #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
added
maintenance
consideRatio
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
@yuvipanda this LGTM and could be merged at this point, but since I pushed a commit I figure I'll let you merge after reviewing it.
Instead they are passed in wherever needed. Cleaner code, and path towards everything being more testable
|
Thanks for the catch and the fix, @GeorgianaElena and @consideRatio! I've pulled, rebased and tested to make sure it works ok. I'll merge this now and deploy to mybinder.org shortly. I'm going to hopefully add optional typechecking (no typescript) to help catch errors like this. |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 23, 2023
jupyterhub/binderhub#1781 Merge pull request #1781 from yuvipanda/noglobals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead they are passed in wherever needed. Cleaner code, and path towards everything being more testable
Ref #774