Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Fix some JSDoc types, and misc details in tests #1783

Merged
merged 1 commit into from
Oct 22, 2023

Commits on Oct 20, 2023

  1. JS: Fix some JSDoc types

    - Optional args get [] around the param name, not the type!
    - Remove extra increased timeout for some jest tests, as they
      are not needed
    - Pass actual URL objects to some of the methods, rather than
      strings. These accidentally worked but shouldn't be relied upon.
    - Import just the function used during tests from node modules,
      rather than the entire module.
    - Fix type of `fetch` to indicate that's actually just an *iterator*,
      not a *generator*.
    
    Ref jupyterhub#774
    yuvipanda committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    bcae809 View commit details
    Browse the repository at this point in the history