Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally use buildx to build for multiple platforms #123

Merged
merged 14 commits into from
Apr 9, 2021

Conversation

manics
Copy link
Member

@manics manics commented Apr 4, 2021

  • New argument --builder to switch between docker build and docker buildx. I've used a choice instead of a flag in case we want to add more builders in future.
  • New argument --platform that takes platforms accepted by docker buildx --platform

@consideRatio
Copy link
Member

The suggested API makes sense to me!

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this looks good overall so far in my mind, i left some comments about thoughts that popped up.

chartpress.py Show resolved Hide resolved
chartpress.py Outdated Show resolved Hide resolved
chartpress.py Outdated Show resolved Hide resolved
@manics manics changed the title WIP: Optionally use buildx to build for multiple platforms Optionally use buildx to build for multiple platforms Apr 6, 2021
@manics manics marked this pull request as ready for review April 6, 2021 21:01
@manics
Copy link
Member Author

manics commented Apr 6, 2021

I've switched to an Enum which I think is a lot clearer! Also added some tests.

I think this is ready to review now. I'll add an option to skip an image (for the Z2JH singleuser image) in a separate PR.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me except that I didn't understand a part about providing * in a list of parameters for a few functions.

I guess there will be a sensible explanation for that though, and then this LGTM!

Thank you @manics for your work! ❤️

chartpress.py Show resolved Hide resolved
@consideRatio consideRatio added the enhancement New feature or request label Apr 9, 2021
@consideRatio consideRatio merged commit 27a3016 into jupyterhub:master Apr 9, 2021
@manics manics deleted the buildx-platforms branch April 10, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants