-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally use buildx to build for multiple platforms #123
Conversation
The suggested API makes sense to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice this looks good overall so far in my mind, i left some comments about thoughts that popped up.
I've switched to an I think this is ready to review now. I'll add an option to skip an image (for the Z2JH singleuser image) in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me except that I didn't understand a part about providing *
in a list of parameters for a few functions.
I guess there will be a sensible explanation for that though, and then this LGTM!
Thank you @manics for your work! ❤️
--builder
to switch betweendocker build
anddocker buildx
. I've used achoice
instead of a flag in case we want to add more builders in future.--platform
that takes platforms accepted bydocker buildx --platform