fix: use of github workflow tokens - different from PATs #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
commented
Jul 23, 2021
Comment on lines
+120
to
+126
| if github_actor and github_token: | ||
| # this format works for a token created for a github | ||
| # workflow's job, no matter what we pass as github_actor. | ||
| return f"https://{github_actor}:{github_token}@github.com/{git_repo}" | ||
| elif github_token: | ||
| # this format works for personal access token, but | ||
| # not for a token created for a github workflow's job. |
There was a problem hiding this comment.
Hmmm... Well... If someone use a personal access token in a github workflow, will this be breaking for them? I'll investigate.
There was a problem hiding this comment.
No! I've learned that a PAT works fine even if it includes some random content before: like this change could end up doing.
There was a problem hiding this comment.
In other words, this is not a breaking change even if a PAT is used in a github workflow.
(I also learned that PATs are recognized by being prefixed ghp_ while the others are prefixed ghs_)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131 - this has bugged me a long time! I got confused by the fact that personal access tokens behaved differently from the
${{ github.token }}one can get from a github workflow.I've tested this well manually now, actually by setting up a dummy repo and running it via SSH etc.