accept non-prerelease baseVersion (append -0.dev) #184
Conversation
allows clearer behavior, simpler config without dictating everyone add the same 0.dev suffix by default
|
I struggle to think if I agree or not based on non-technical aspects like what our goals are. Due to that, I figure I'll write down goals as I see them so we can agree/disagree on them before thinking about technical parts. Desired outcomesSemver2 version sorting to position dev releases with a 1.2.0-0.dev.git.5500.habc
1.2.0-beta.1
1.2.0-beta.1.git.5600.habc
1.2.0
2.0.0-0.dev.git.5700.h7123
2.0.0-beta.1
2.0.0-beta.1.git.5800.h234
2.0.0-beta.2
2.0.0-beta.2.git.5900.h345
2.0.0Current developer experience (DX)# baseVersion is 2.0.0-0.dev
2.0.0-0.dev.git.5700.h7123
2.0.0-beta.1
# baseVersion updated to 2.0.0-beta.1
2.0.0-beta.1.git.5800.h234
2.0.0-beta.2
# baseVersion updated to 2.0.0-beta.2
2.0.0-beta.2.git.5900.h345
2.0.0
# baseVersion updated to 2.0.1-0.dev
2.0.1-0.dev.git.6000.h456Desired developer experience (DX)Easy and reliable workflow Desired code baseSimple logic, easy to understand, communicate how it works, and as a consequence also to maintain it long term and help this project be useful |
|
I'm not sure how related this PR is to the discussion in jupyterhub/zero-to-jupyterhub-k8s#2860 . It only changes the interpretation of baseVersion without a prerelease as equivalent to I suppose it does relate to the recommended workflow for charts that publish prerelease tags. Accepting stable versions is required for compatibility with something like tbump. |
minrk
changed the title
|
If this enables use of tbump I'm sold, I'd love to see us able to use a tool like that as we would get something reliable and easy to document in RELEASE.md files. |
consideRatio
force-pushed
the
dont-require-0.dev
branch
from
22341ef
to
e4a8947
Compare
|
I'm going to write a test tomorrow that goes through all the release phases using tbump with baseVersion and update the baseVersion notes to recommend use with tbump. |
|
Thank you soo much for your thorough work on this @minrk!!!!! ❤️ 🎉 |
and add test case covering release process - no tag - tbump beta - commit - tbump final - back to dev
minrk
force-pushed
the
dont-require-0.dev
branch
from
d9f65bc
to
3ea5d40
Compare
|
Added tbump test case and mentions in readme |
allows clearer behavior, simpler config without dictating everyone add the same 0.dev suffix by default.
No practical effect, other than
baseVersion: 1.2.3is equivalent tobaseVersion: 1.2.3-0.devinstead of raising an error telling you to use1.2.3-0.dev.Importantly, this is required for chartpress to be used with an automatic version-bumping tool like
tbump.