test not needing extra args

jupyterhub · Mar 29, 2024 · 780d98e · 780d98e
1 parent 91e2446
commit 780d98e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -28,7 +28,6 @@ jobs:
       matrix:
         include:
           - vncserver: tigervnc
-            vncserver_args: -localhost no --I-KNOW-THIS-IS-INSECURE
           - vncserver: turbovnc
 
     steps:
@@ -59,7 +58,7 @@ jobs:
       - name: Test vncserver
         if: always()
         run: |
-          container_id=$(docker run -d -it -p 5901:5901 test vncserver -xstartup /opt/install/jupyter_remote_desktop_proxy/share/xstartup -verbose -fg -geometry 1680x1050 -SecurityTypes None -rfbport 5901 ${{ matrix.vncserver_args }})
+          container_id=$(docker run -d -it -p 5901:5901 test vncserver -xstartup /opt/install/jupyter_remote_desktop_proxy/share/xstartup -verbose -fg -geometry 1680x1050 -SecurityTypes None -rfbport 5901)
           sleep 1
 
           docker exec -it $container_id timeout --preserve-status 1 nc -v localhost 5901 2>&1 | tee -a /dev/stderr | \
@@ -78,7 +77,7 @@ jobs:
       - name: Test websockify'ed vncserver
         if: always()
         run: |
-          container_id=$(docker run -d -it -p 5901:5901 test websockify --verbose --log-file=/tmp/websockify.log --heartbeat=30 5901 -- vncserver -xstartup /opt/install/jupyter_remote_desktop_proxy/share/xstartup -verbose -fg -geometry 1680x1050 -SecurityTypes None -rfbport 5901 ${{ matrix.vncserver_args }})
+          container_id=$(docker run -d -it -p 5901:5901 test websockify --verbose --log-file=/tmp/websockify.log --heartbeat=30 5901 -- vncserver -xstartup /opt/install/jupyter_remote_desktop_proxy/share/xstartup -verbose -fg -geometry 1680x1050 -SecurityTypes None -rfbport 5901)
           sleep 1
 
           docker exec -it $container_id websocat --binary --one-message --exit-on-eof "ws://localhost:5901/" 2>&1 | tee -a /dev/stderr | \