Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify developmental dockerfile #58

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Simplify developmental dockerfile #58

merged 1 commit into from
Aug 26, 2023

Conversation

yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Aug 25, 2023 •
edited
Loading

  • Don't run apt-get upgrade, is not necessary
  • Use tigervnc from apt rather than what we turbovnc. This allows the image to work on ARM machines as well as getting us a newer version of everything. Also it's possible that TurboVNC doesn't work right now, see TurboVNC broken since commit 447bf86, still in 1.2.1 #54
  • Reorder and use COPY --chown to make rapid development faster with better caching
  • Remove firefox install from apt, as that no longer works anyway (it' a snap). That's set up with Add images that can be used directly by end users #51 correctly.

@yuvipanda
Simplify developmental dockerfile
25ae80b 
- Don't run apt-get upgrade, is not necessary
- Use tigervnc from apt rather than what we ship. This allows the
  image to work on ARM machines as well as getting us a newer version
  of everything.
- Reorder and use COPY --chown to make rapid development faster with
  better caching
- Remove firefox install from apt, as that no longer works anyway (it'
  a snap). That's set up with
  #51
  correctly
@yuvipanda yuvipanda requested a review from manics August 25, 2023 20:47
@github-actions
Copy link

Binder 👈 Launch a binder notebook on this branch for commit 25ae80b

I will automatically update this comment whenever this PR is modified

yuvipanda referenced this pull request Aug 25, 2023
@cmd-ntrf
Remove "/usr/bin" prefix in front of dbus-launch in xstartup
ffc9477 
This allows xstartup to work with environment where dbus-launch is
in PATH while not installed in standard /usr/bin.
@yuvipanda yuvipanda mentioned this pull request Aug 25, 2023
Closed
6 tasks
consideRatio
consideRatio approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being recently opened and not super-trivial change, I'll let you self merge if its ready instead of merge myself now. This LGTM!

Could you double-check that there isn't any light-locker package installed any more after building this image?

@yuvipanda
Copy link
Contributor Author

Yep, light-locker not present!

(base) jovyan@cbb712ae6bc7:~$ dpkg -l | grep light
ii  libdaemon0:arm64                          0.14-7.1ubuntu3                         arm64        lightweight C library for daemons - runtime library

@yuvipanda yuvipanda merged commit 3aac4d2 into main Aug 26, 2023
3 checks passed
@yuvipanda yuvipanda deleted the simplify-dockerfile branch August 26, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

@manics manics Awaiting requested review from manics

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @consideRatio