-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the UI to be much nicer #78
Conversation
👈 Launch a binder notebook on this branch for commit c793783 I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 0faedee 👈 Launch a binder notebook on this branch for commit 0e938ce 👈 Launch a binder notebook on this branch for commit ee058cf 👈 Launch a binder notebook on this branch for commit ac8c768 👈 Launch a binder notebook on this branch for commit b47a85d 👈 Launch a binder notebook on this branch for commit 0d9747e 👈 Launch a binder notebook on this branch for commit d4c9223 👈 Launch a binder notebook on this branch for commit 651cb08 👈 Launch a binder notebook on this branch for commit 408a4fc 👈 Launch a binder notebook on this branch for commit efecd5e 👈 Launch a binder notebook on this branch for commit 7c28872 👈 Launch a binder notebook on this branch for commit 4d1a878 👈 Launch a binder notebook on this branch for commit a018435 👈 Launch a binder notebook on this branch for commit b1a264d |
- Remove ability to connect to arbitrary hosts and ports via query params. We already required websockify anyway, so this never worked. Plus, we only care about using the viewer for our own purposes, not as a general purpose novnc thing - Get rid of the ctrlAltDelete function. It's not particularly useful in this context. I will work on adding more UI here, but this location is a good place for other buttons
This is almost always a random sequence of strings and is not useful.
Was missed when I undid all the queryparam stuff
- Include a CSS reset - Use Jupyter Brand Colors - Add a helpful bit of info for clipboard popout
- Uses floating-ui for a proper popover for the clipboard - Sort out the menu to look much better
- Has a hover state and an active state
I wanna move |
Looks nice! |
@manics when I tried it, it showed me the logout window. And if I tried to logout, it mostly just bricked my desktop session - I think it stopped dbus and xfce-session, but not anything else. That's one of the primary reasons I removed it, as our handling of how these processes are supervised (they just double fork and go on their merry way) doesn't help. I'm going to add a dropdown menu with lesser used options - primarily intended for a checkbox for 'scale to fit'. But I can put a ctrl-alt-delete button there too. Are you ok with that coming in a later PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK! I've adding a tracking issue #83
Yay, thank you, @manics :) |
There's a lot of helpful UI changes to the desktop that haven't been released yet (primarily jupyterhub/jupyter-remote-desktop-proxy#78). In particular, the hub control panel is much easier to access, and so is the clipboard. Until a release is made (jupyterhub/jupyter-remote-desktop-proxy#87), we can install it directly from source
Built on top of #77
This PR is a combination of JS cleanup as well as UI cleanup.