Add an integration test for VNC + websockify #93
Closed
Commits on Jun 13, 2024
-
Add an integration test for VNC + websockify
This tests the following components: 1. The VNC server 2. websockify 3. Jupyter Server Proxy 4. The desktop environment itself It does so by: 1. Building the container image 2. Starting a container with that image, with jupyter server running inside. 3. Connecting to the container via websockets, authenticating and exposing the websocket connection as a regular TCP socket on localhost via [websocat](https://github.com/vi/websocat) 4. Taking a screenshot of the remote desktop by connecting to it through `vncdotool`. This requires a tcp connection, hence the double proxying with websocat 5. Verify that the image produced by the screenshot is the same as a reference image we have. This only misses the noVNC + JS from testing, but otherwise represents a massive improvement to the status quo!
-
-
-
Dynamically allocate forwarded port
Prevents clashes between multiple runs Also remove some old commented out code
-
-
-
-
-
-
-
-
-
-
Don't pass "-it" to docker run
Doesn't actually need to be interactive, we primarily care about sharing stdout
-
-
-
-
-
-
Try increasing shm size on docker run
Maybe this is what github actions needs
-
Revert "Try increasing shm size on docker run"
It did nothing This reverts commit a33a447.
-
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.