-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TigerVNC detection for non-apt installations #96
Conversation
👈 Launch a binder notebook on this branch for commit 2896efa I will automatically update this comment whenever this PR is modified |
Does this look right to you @goekce? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it works for the issue reporter!
I could not test on an installation due to lack of capacity right now. I believe the command line arguments to tigervnc and turbovnc may be different. In #69 I had mentioned that jupyter-remote-desktop-proxy/jupyter_remote_desktop_proxy/__init__.py Lines 34 to 35 in 024ab7d
I searched for but could neither find any reference to https://github.com/search?q=repo%3ATigerVNC%2Ftigervnc%20xstartup&type=code Further arguments must also be tested: jupyter-remote-desktop-proxy/jupyter_remote_desktop_proxy/__init__.py Lines 37 to 46 in 024ab7d
This is the reason why I think in the long term the arguments should be configurable by the user. |
Thank you for reviewing @yuvipanda and @goekce!! |
I think we checked the case sensitive TigerVNC string which works if TigerVNC was installed via
apt
, but may not work when installed in another way. On the other hand, at those times, checking for the case insensitive string would work then. So, this PR makes the check case insensitive.Thank you @goekce for your thorough issue report!!