Merge pull request #441 from consideRatio/pr/fix-logging-failure

tests: fix failure to log error after all retries failed
jupyterhub · Jan 4, 2024 · a65437a · a65437a
2 parents 98eff01 + b0723f9
commit a65437a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -99,6 +99,7 @@ def wait_until_urlopen(url, **kwargs):
             urlopen(url, **kwargs)
             break
         except URLError:
+            retries -= 1
             if not retries:
                 print(
                     f"{url} not ready, aborting",
@@ -109,7 +110,6 @@ def wait_until_urlopen(url, **kwargs):
                 f"{url} not ready, will try again in 0.5s [{retries} retries]",
                 flush=True,
             )
-            retries -= 1
         time.sleep(0.5)