Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jupyterlab extension id to match convention #323

Closed
wants to merge 1 commit into from

Conversation

cmd-ntrf
Copy link
Contributor

Allow disabling the extension using the name reported for the plugin by jupyter labextension CLI tools.

More details in issue #322

Allow disabling the extension using the name reported
for the plugin by jupyter labextension CLI tools.
@consideRatio
Copy link
Member

Important, this was considered a breaking change:

The name should probably follow the upstream pattern, e.g. @jupyterlab/server-proxy:plugin, but shouldn't be changed until a major version bump of this package (e.g 4.0.0).

@consideRatio
Copy link
Member

consideRatio commented Jun 24, 2022

Should this be named @jupyterlab/server-proxy to match the legacy npm package name though, or should it be named something more coupled to its current name - jupyter-server-proxy - the PyPI package? The current name jupyterlab-server-proxy doesn't seem right in any way though.

@yuvipanda
Copy link
Contributor

I always imagine that extensions under the @jupyterlab/ extension naming are in the jupyterlab org, rather than the jupyterhub org.

@consideRatio
Copy link
Member

This repo has a npm package in the jupyterlab org, but we dont need it for jupyterlab 3+ so should we reference it here now?

I think we want to reference a name including the repo name/pypi name and maybe also jupyterhub/ - but not the old npm package unless its really to point to some npm package - in whatever format is common.

@bollwyvl
Copy link
Collaborator

bollwyvl commented Jun 25, 2022 via email

@consideRatio
Copy link
Member

Hey, triaging open PRs and marking this as a draft.

I figure that unless we can name this @jupyterhub/jupyter-server-proxy that seems proper, we shouldn't make a breaking change about this.

If we can do that depends on getting control of the npm organization first and we are awaiting a claim to take control of an existing jupyterhub organization now in jupyterhub/team-compass#562 (comment).

@consideRatio
Copy link
Member

consideRatio commented Dec 28, 2022

We have control of the jupyterhub organization, @minrk @manics @yuvipanda what do you think - should we go for it?

I like the idea of decoupling this from being under @jupyterlab and named inconsistently like server-proxy instead of jupyter-server-proxy as the repo and python package is named.

Is it okay if I move towards resolving this by defining a NPM package / setting up credentials etc for the CI system to push to @jupyterhub/jupyter-server-proxy going onwards?

@consideRatio
Copy link
Member

Closing in favor of #363. We need to make more significant changes than just the one-liner. If there is agreement in this linked github issue, I'll go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants