Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package license #3

Merged
merged 3 commits into from
May 26, 2020
Merged

Package license #3

merged 3 commits into from
May 26, 2020

Conversation

ericdill
Copy link
Contributor

Hi @yuvipanda. I'm adding jupyterhub-idle-culler to conda-forge. I see that the license isn't packaged with the source. According to the BSD-3-clause license we gotta include the license with the source. This PR adds the bits to this repo to include the license in the tarball the next time you release. I can bundle the license in the conda-forge package until you need to make a new release (in other words, please don't feel like I'm pressuring you to make another release just for this license!).

Without the MANIFEST.in:

$ python setup.py sdist
running sdist                                                                                                                                
running egg_info                                                                                                                             
creating jupyterhub_idle_culler.egg-info                              
writing jupyterhub_idle_culler.egg-info/PKG-INFO                      
writing dependency_links to jupyterhub_idle_culler.egg-info/dependency_links.txt
writing entry points to jupyterhub_idle_culler.egg-info/entry_points.txt                                                                    
writing requirements to jupyterhub_idle_culler.egg-info/requires.txt                                                                         
writing top-level names to jupyterhub_idle_culler.egg-info/top_level.txt                                                                 
writing manifest file 'jupyterhub_idle_culler.egg-info/SOURCES.txt'   
reading manifest file 'jupyterhub_idle_culler.egg-info/SOURCES.txt'                                                                          
writing manifest file 'jupyterhub_idle_culler.egg-info/SOURCES.txt'                                                                          
running check                                                                                                                                
warning: check: missing required meta-data: url                       
                                                                      
warning: check: missing meta-data: either (author and author_email) or (maintainer and maintainer_email) must be supplied
                                                                                                                                             
creating jupyterhub-idle-culler-1.0                                                                                                          
creating jupyterhub-idle-culler-1.0/jupyterhub_idle_culler                                                                                   
creating jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info                                                                          
copying files to jupyterhub-idle-culler-1.0...                                                                                               
copying README.rst -> jupyterhub-idle-culler-1.0                                                                                             
copying setup.py -> jupyterhub-idle-culler-1.0                                                                                               
copying jupyterhub_idle_culler/__init__.py -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler                  
copying jupyterhub_idle_culler/__main__.py -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler                                              
copying jupyterhub_idle_culler.egg-info/PKG-INFO -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info                               
copying jupyterhub_idle_culler.egg-info/SOURCES.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info                            
copying jupyterhub_idle_culler.egg-info/dependency_links.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info                  
copying jupyterhub_idle_culler.egg-info/entry_points.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info                       
copying jupyterhub_idle_culler.egg-info/requires.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info                           
copying jupyterhub_idle_culler.egg-info/top_level.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info   
Writing jupyterhub-idle-culler-1.0/setup.cfg                                                                                                 
creating dist                                                                                                                                
Creating tar archive
removing 'jupyterhub-idle-culler-1.0' (and everything under it)

(no COPYING.md)

With the MANIFEST.in:

running sdist
running egg_info
creating jupyterhub_idle_culler.egg-info
writing jupyterhub_idle_culler.egg-info/PKG-INFO
writing dependency_links to jupyterhub_idle_culler.egg-info/dependency_links.txt
writing entry points to jupyterhub_idle_culler.egg-info/entry_points.txt
writing requirements to jupyterhub_idle_culler.egg-info/requires.txt
writing top-level names to jupyterhub_idle_culler.egg-info/top_level.txt
writing manifest file 'jupyterhub_idle_culler.egg-info/SOURCES.txt'
reading manifest file 'jupyterhub_idle_culler.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'jupyterhub_idle_culler.egg-info/SOURCES.txt'
running check
creating jupyterhub-idle-culler-1.0
creating jupyterhub-idle-culler-1.0/jupyterhub_idle_culler
creating jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info
copying files to jupyterhub-idle-culler-1.0...
copying COPYING.md -> jupyterhub-idle-culler-1.0
copying MANIFEST.in -> jupyterhub-idle-culler-1.0
copying README.rst -> jupyterhub-idle-culler-1.0
copying setup.py -> jupyterhub-idle-culler-1.0
copying jupyterhub_idle_culler/__init__.py -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler
copying jupyterhub_idle_culler/__main__.py -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler
copying jupyterhub_idle_culler.egg-info/PKG-INFO -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info
copying jupyterhub_idle_culler.egg-info/SOURCES.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info
copying jupyterhub_idle_culler.egg-info/dependency_links.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info
copying jupyterhub_idle_culler.egg-info/entry_points.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info
copying jupyterhub_idle_culler.egg-info/requires.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info
copying jupyterhub_idle_culler.egg-info/top_level.txt -> jupyterhub-idle-culler-1.0/jupyterhub_idle_culler.egg-info
Writing jupyterhub-idle-culler-1.0/setup.cfg
creating dist
Creating tar archive
removing 'jupyterhub-idle-culler-1.0' (and everything under it)

I also noticed some warnings in the python setup.py sdist output, so I added the url and author info. Happy to pull that back out if you'd rather not include it.

@yuvipanda yuvipanda merged commit 498e97c into jupyterhub:master May 26, 2020
@yuvipanda
Copy link
Collaborator

Woop, thanks @ericdill! I'll let the next release pick this up whenever it happens...

@consideRatio consideRatio added the documentation Improvements or additions to documentation label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants