Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select profile if any of its choices are interacted with #729

Merged
merged 8 commits into from
May 18, 2023
Merged

Select profile if any of its choices are interacted with #729

merged 8 commits into from
May 18, 2023

Commits on May 1, 2023

  1. select radio when corresponding select is changed, addresses #696

    @batpad
    batpad committed May 1, 2023
    Configuration menu
    Copy the full SHA
    969fcba View commit details
    Browse the repository at this point in the history

  2. minor, edit comment and format JS

    @batpad
    batpad committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c448154 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. bind to click event, not change, so profile gets selected even when o… 

    …ption is not changed
    @batpad
    batpad committed May 17, 2023
    Configuration menu
    Copy the full SHA
    bf760b4 View commit details
    Browse the repository at this point in the history

  2. add click-to-select profile to label as well

    @batpad
    batpad committed May 17, 2023
    Configuration menu
    Copy the full SHA
    36368cc View commit details
    Browse the repository at this point in the history

  3. cleanup formatting, comments

    @batpad
    batpad committed May 17, 2023
    Configuration menu
    Copy the full SHA
    79f54b7 View commit details
    Browse the repository at this point in the history

  4. use <span> instead of <label>, remove js to handle clicking on labels… 

    … for the select
    @batpad
    batpad committed May 17, 2023
    Configuration menu
    Copy the full SHA
    9904a70 View commit details
    Browse the repository at this point in the history

  5. autoformatting

    @batpad
    batpad committed May 17, 2023
    Configuration menu
    Copy the full SHA
    28b3281 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. revert to using label instead of span, add back form-control class to… 

    … select
    @batpad
    batpad committed May 18, 2023
    Configuration menu
    Copy the full SHA
    25bf703 View commit details
    Browse the repository at this point in the history