Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update images used in tests #841

Merged
merged 2 commits into from
Jun 12, 2024
Merged

update images used in tests #841

merged 2 commits into from
Jun 12, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Jun 12, 2024

they were very out of date

for whatever reason, I couldn't run the tests locally with the old images, but they run fine with these

closes #833

they were very out of date
@consideRatio
Copy link
Member

consideRatio commented Jun 12, 2024

Nice, closes #833 i think!

I think it could make sense to use latest or similar instead of a version tag here, as we otherwise will fail to update this is require adding a machinery that updates it. Self merge as is or update then merge!

matches host version in pip and default user image
@minrk
Copy link
Member Author

minrk commented Jun 12, 2024

@consideRatio good point! We don't have upper bound on the hub and :latest is the default tag in KubeSpawner.image, so latest is probably the most consistent choice with versions coming from elsewhere.

@minrk minrk merged commit 593405d into jupyterhub:main Jun 12, 2024
9 checks passed
@minrk minrk deleted the bump-test-images branch June 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are we testing against JupyterHub 1.3?
2 participants