Allow list based config volumes and volume_mounts to be assigned dictionaries
#843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue to support these values to be defined as Lists for backwards compatibility. When defined as Dicts, the items are sorted lexicographically by the keys and the values are used as volumes / volume mounts. This enables easy overriding or extension. refs NASA-IMPACT/veda-jupyterhub#44 (comment) jupyterhub/jupyterhub#4822
for more information, see https://pre-commit.ci
|
@yuvipanda Could you please take a look at these changes and let me know if they look good? If this looks ok, I'll proceed to make similar updates for other traitlets that need to support dictionaries. Thanks! |
yuvipanda
approved these changes
Jul 18, 2024
| @@ -1869,6 +1891,12 @@ def _expand_all(self, src): | |||
| else: | |||
| return src | |||
|
|
|||
| def _sorted_dict_values(self, src): | |||
There was a problem hiding this comment.
Can you add a docstring here?
|
Thanks for the review @yuvipanda! I have added the missing docstring. I'll open a follow up PR to make similar updates for other traitlets that need to support dictionaries. |
|
Thanks @sunu! |
sunu
added a commit
to sunu/kubespawner
that referenced
this pull request
Jul 26, 2024
As a continuation of jupyterhub#843, allow more pod properties to be defined as dictionaries for easy overriding.
4 tasks
consideRatio
changed the title
volumes and volume_mounts to be defined as Dicts
consideRatio
changed the title
volumes and volume_mounts to be defined as Dictsvolumes and volume_mounts to be assigned dictionaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made the following changes:
Union(trait_types=[List(), Dict()])so that they can be defined as dictionaries (for easy overriding) or as lists (for backwards compatibility)Defining these values as dictionaries enables easy overriding. refs jupyterhub/jupyterhub#4822 and NASA-IMPACT/veda-jupyterhub#44