Support for multiple bind templates #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. modified bind_Dn_template from Unicode to List 2. Added the logic to handle multiple DNs
|
Thank you very much for the patch! Apologies for the late review, I've been on vacation. |
yuvipanda
previously requested changes
Oct 8, 2016
| @@ -28,7 +28,7 @@ def _server_port_default(self): | |||
| help='Use SSL to encrypt connection to LDAP server' | |||
| ) | |||
|
|
|||
| bind_dn_template = Unicode( | |||
| bind_dn_template = List( | |||
There was a problem hiding this comment.
I think we should allow this to continue to be a Unicode, to prevent backwards compatibility issues. This could be done with a Union traitlet type I think.
| conn = ldap3.Connection(server, user=userdn, password=password) | ||
| self.log.debug("GOT LDAP CONNECTION FOR USER: '%s'", conn) | ||
| isBound = conn.bind() | ||
| self.log.debug("CONN_BIND: "+ str(isBound) + ":" + username ) |
There was a problem hiding this comment.
For all logging, you can use format strings instead of explicit concatenation.
self.log.debug('Attempting to bind with dn %s', dn)|
|
||
| isBound = False | ||
| for dn in self.bind_dn_template: | ||
| #self.log.debug("LOOPING DN") |
There was a problem hiding this comment.
Remove the commented out line?
| for dn in self.bind_dn_template: | ||
| #self.log.debug("LOOPING DN") | ||
| userdn = dn.format(username=username) | ||
| self.log.debug("DN: '%s'", userdn) |
There was a problem hiding this comment.
These four logging statements can probably be collapsed into two:
- Specify the username being checked and the userdn being used
- Specify status of bind
|
Hey @kishorchintal. Are you still interested in taking this patch through, or would you like me to work through making these changes myself? |
|
I'll probably pick this up in a week or so if there's no response :) |
|
Hi Yuvi,
Apologies for delayed response. I've been away from work for past couple of
weeks. I'll try to get this patch to you next week.
Kishor
…On Sun, Nov 27, 2016 at 5:06 PM Yuvi Panda ***@***.***> wrote:
I'll probably pick this up in a week or so if there's no response :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APTv_2GSxGlgGaTqlrZOtcaMQow4xSZSks5rCikfgaJpZM4KJXXR>
.
|
|
Thanks! Looking forward to it :)
On Tue, Nov 29, 2016 at 8:56 AM, kishorchintal <notifications@github.com>
wrote:
… Hi Yuvi,
Apologies for delayed response. I've been away from work for past couple of
weeks. I'll try to get this patch to you next week.
Kishor
On Sun, Nov 27, 2016 at 5:06 PM Yuvi Panda ***@***.***>
wrote:
> I'll probably pick this up in a week or so if there's no response :)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/jupyterhub/ldapauthenticator/
pull/23#issuecomment-263162152>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/APTv_
2GSxGlgGaTqlrZOtcaMQow4xSZSks5rCikfgaJpZM4KJXXR>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB23ixfKgkOnmZAjQqHc7_UL1Af3FP0ks5rC3hEgaJpZM4KJXXR>
.
--
Yuvi Panda T
http://yuvi.in/blog
|
|
@yuvipanda - I've made the changes suggested, pls review. |
modularized the code
|
Looks like review has been addressed. Thanks, @kishorchintal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.