New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolved_username regex #75

Merged

dhirschfeld merged 1 commit into jupyterhub:master from dhirschfeld:regex-fail

Jun 8, 2018

Collaborator

dhirschfeld commented Jun 8, 2018 •

edited

Loading

The fix in #68 wasn't correct as the regex will swallow the previous character:

>>> re.subn(r"[^\\],", r"\,", "Hirschfeld, David")[0]
'Hirschfel\\, David'

...the workaround is to capture the swallowed character and reinsert it:

>>> re.subn(r"([^\\]),", r"\1\,", "Hirschfeld, David")[0]
'Hirschfeld\\, David'

Not sure if that is the most elegant solution, but it does seem to fix the problem...


          Fix resolved_username regex

7b506af

dhirschfeld merged commit 8220fc6 into jupyterhub:master

dhirschfeld deleted the regex-fail branch

June 8, 2018 04:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet