maint: transition to pypi trusted workflow release, put tbump conf in pyproject.toml #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/new-release-system
branch
from
2506391
to
f3b784f
Compare
consideRatio
changed the title
|
Forging ahead to get a 1.2.0 release out with jupyterhub 4 compatibility. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have started to adopt a new way to provide credentials to push a package to PyPI as discussed here. This has worked out fine so far, so I'm transitioning this repo to that as well.
In practice with this setup, we don't need a github secret with a PyPI deployment token from a user account, but can instead say "we trust this github repo's workflow called release.yaml to push releases". I've setup credentials in PyPI etc for that, and cleaned up other permissions.