dependabot: monthly updates of github actions #50
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
LGTM! 🚀 🚀 |
|
Thanks for reviewing this @Sheila-nk and for your warm encouraging spirit!!! To me it makes a big difference as a contributor, thank you! Sometimes when I review and approve something, I ask for someone else to review it also before we get something merged - but its a compromise of course since we are time constrainted. If a change is breaking or changing behavior of the projects code or a larger feature being added, I typically request another person to review it as well before merge. What do you think about following up this approval with a clarification on what you think makes sense to do before a merge, or going for a merge directly? There are guidance on the "when to merge" section from the jupyterhub team compass describing something like that. The same guidance also suggests I could also merge this now with your approval, but not all PR authors has the permissions to do so, so I think its a good practice to avoid using such priviledge. |
|
@consideRatio Oh yes, I apologize! I should have followed up the approval with a merge or a message that you should feel free to merge this PR. |
.github/dependabot.yaml
Outdated
| # | ||
| # Notes: | ||
| # - Status and logs from dependabot are provided at | ||
| # https://github.com/jupyterhub/jupyterhub/network/updates. |
There was a problem hiding this comment.
I just noticed that we might need to make an edit to the link provided for dependabot's status and logs.
Co-authored-by: Sheila <114513578+Sheila-nk@users.noreply.github.com>
|
Thank you @consideRatio for your contribution to this repository ❤️ |
|
Congrats on your first merged pull request in this project! 🎉 |
This is one of several PRs opened in the juptyterhub github organization to systematically configure dependabot to update github actions on a monthly basis, for more information see jupyterhub/team-compass#636.