pre-commit: chartpress --reset on Chart.yaml/values.yaml changes #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/pre-commit-chartpress
branch
from
81c3f56
to
3c17834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was skeptical, but now I fully understand that pre-commit really doesn't bother you unless you change the specific liens of codes in the specific file that would be influenced.
For example, assume you have run
chartpress --skip-build, the Chart.yaml file will have its lineversion: 0.10.6-n123.h1234567set, which should be0.0.1-set.by.chartpressby default. But, if you commit another line change in this file, you will be fine! Havingchartpress --resetrun as part of pre-commit won't change a thing and everything will be fine.