Ensure hub container is first by appending instead of prepending hub.extraContainers #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extraContainers By doing this, you'd be able to do `kubectl logs deploy/hub` and get the hub containers logs no matter what. Before, you'd get the first listed `hub.extraContainer` instead and have to add `--container=hub` to ensure getting the hub containers logs. I'm maintaining a deployment where we use hub.extraContainers, and by doing so, have been required to specify `-c hub` anytime I want logs, because its not the first container in the pod specs list of containers.
consideRatio
force-pushed
the
pr/always-hub-first
branch
from
6ba8003
to
45e6fbd
Compare
|
@yuvipanda @sgibson91 @GeorgianaElena the need to specify |
manics
approved these changes
Oct 18, 2024
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 18, 2024
jupyterhub/zero-to-jupyterhub-k8s#3546 Merge pull request #3546 from consideRatio/pr/always-hub-first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this, you'd be able to do
kubectl logs deploy/huband get thehub containers logs no matter what. Before, you'd get the first listed
hub.extraContainerinstead and have to add--container=hubto ensuregetting the hub containers logs.
I'm maintaining a deployment where we use hub.extraContainers, and by
doing so, have been required to specify
-c hubanytime I want logs,because its not the first container in the pod specs list of containers.