Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a GitHub App for releasing with the Jupyter Releaser #67

Closed
jtpio opened this issue Mar 7, 2024 · 5 comments
Closed

Create a GitHub App for releasing with the Jupyter Releaser #67

jtpio opened this issue Mar 7, 2024 · 5 comments

Comments

@jtpio
Copy link
Member

jtpio commented Mar 7, 2024

We should look into following this change in Jupyter Releaser to avoid using the ADMIN_GITHUB_TOKEN: jupyter-server/jupyter_releaser#557

This would mean creating an org wide GitHub app, and updating the releaser workflow and each repo to use the app.

@jtpio
Copy link
Member Author

jtpio commented May 2, 2024

Since we don't have a way to share secrets between jupyterlab-contrib admins (no password manager), maybe each maintainer could generate its own private key for the GitHub app?

image

@jtpio
Copy link
Member Author

jtpio commented May 22, 2024

FYI @fcollonval I was planning to start looking into this and create the GitHub App.

Just checking if you had any preference on how to manage the secret for the app. Do you still have access to the Jupyter 1Password? If so we could maybe store the credentials there.

@fcollonval
Copy link
Member

@jtpio I don't have access to the 1Password account. But if most owners of this org have, I'm fine.

Pinging @krassowski and @martinRenou for awareness

@fcollonval
Copy link
Member

I added a GitHub App. And yes the best for this org is for owners to generate private keys when migrating a repo to use the app for release.

@jtpio I guess we can close the issue?

@jtpio
Copy link
Member Author

jtpio commented Jul 4, 2024

Also thinking more about it, since jupyterlab-contrib is not an official Jupyter subproject, it's not clear whether we should start storing its secrets in the Jupyter 1Password.

I guess the "1 key per owner" approach sounds like the easiest for now. We can always delete, regenerate keys and update the release environment secrets if needed.

@jtpio jtpio closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants