Remove the need for an ADMIN_GITHUB_TOKEN #557
Conversation
|
Nice, thanks! |
example-workflows/prep-release.yml
Outdated
| # description: "Set a placeholder in the changelog and don't publish the release." | ||
| # required: false | ||
| # type: boolean | ||
| silent: |
There was a problem hiding this comment.
iirc this was left commented so that the input does not show up in the UI as this is more of an advanced feature (discussed in #526)
There was a problem hiding this comment.
Okay fair, I'll comment it out
There was a problem hiding this comment.
Thanks a lot @blink1073
I have some minor questions and suggestions.
| # The following are needed if you use legacy PyPI set up | ||
| # PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }} | ||
| # PYPI_TOKEN_MAP: ${{ secrets.PYPI_TOKEN_MAP }} | ||
| # TWINE_USERNAME: __token__ |
There was a problem hiding this comment.
Should we keep this for now as we don't remove legacy PyPI publication yet?
There was a problem hiding this comment.
I think having it in the docs is enough, new projects should be using Trusted Publishing.
| # The following are needed if you use legacy PyPI set up | ||
| # PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }} | ||
| # PYPI_TOKEN_MAP: ${{ secrets.PYPI_TOKEN_MAP }} | ||
| # TWINE_USERNAME: __token__ |
|
|
||
| <details><summary>Using PyPI token (legacy way)</summary> | ||
| - [ ] Create a "release" [environment](https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment) on your repository and add an `APP_ID` Environment Variable and `APP_PRIVATE_KEY` secret. |
There was a problem hiding this comment.
Should we advice to allow that environment only on protected branches?
There was a problem hiding this comment.
Good catch, updated
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
for more information, see https://pre-commit.ci
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
I need to merge and iterate so I can release. |
|
Thanks a lot @blink1073 for finishing up this PR. |
Fixes #505.