Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling missing from the npm package #32

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

martinRenou
Copy link
Member

No description provided.

@@ -24,7 +24,7 @@
"files": [
"schema/**/*.json",
"lib/**/*.{d.ts,eot,gif,html,jpg,js,js.map,json,png,svg,woff2,ttf}",
"style/**/*.{css,.js,eot,gif,html,jpg,json,png,svg,woff2,ttf}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the .js entry was the one responsible for not a single style file being included, maybe that's a blob syntax error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need all those file extensions anyway

@martinRenou martinRenou merged commit 20abcd9 into jupyterlab-contrib:master Mar 22, 2022
@martinRenou martinRenou deleted the fix_style_upload branch March 22, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant