Change Ctrl + Enter to render Markdown cells
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
krassowski
approved these changes
Nov 11, 2023
|
Thanks so much! |
|
@firai this still needs to be released right? |
|
Correct, this hasn't been released yet |
|
do you have the poewr to make a release? if not im happy to do it, and also to try to figure out getting you the ability. instructions on how live here: https://jupyter-releaser.readthedocs.io/en/latest/get_started/making_release_from_repo.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #120
Code changes
Don't re-enter edit mode for Markdown cells in
vim:run-cell-and-edit.Additional context
This command has been contradictory for Markdown cells, as JL exits edit mode when rendering Markdown by design. This command previously prioritized staying in edit mode, which effectively resulted in no actions being taken for Markdown cells when the command is called.
Since the user pressed a key binding to call the command and therefore presumably expected something to happen, I think this proposed change to prioritize rendering the cell for Markdown cells is acceptable.