Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of a file editor toolbar button to the toolbar examples #189

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ktaletsk
Copy link

@ktaletsk ktaletsk commented Jan 29, 2022

Implements #188


This will close #188

@welcome
Copy link

welcome bot commented Jan 29, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@ktaletsk
Copy link
Author

For some reason, I can't get Github to correctly match index.ts in the old and new location

@fcollonval
Copy link
Member

For some reason, I can't get Github to correctly match index.ts in the old and new location

The amount of changes is too high for git to consider it as a rename.

Would you mind fixing the CI (in particular the linter)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example of toolbar button in text editor (+for particular file extension)
2 participants