-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shout-button-message widget example. #243
Added shout-button-message widget example. #243
Conversation
@fcollonval This is part of the same effort as the toparea text widget example if you can look this one over as well maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ericsnekbytes
You should improve a bit the logic to improve separation of concerns.
Could you please add an integration test and update the README to describe what the code is doing?
Two notebooks were committed by mistake.
@fcollonval Can you re-review/approve? Thanks. EDIT: I need to add tests to this still actually. |
@fcollonval If you have time to review I'd like to get this approved, the Dual Compatibility document (see top post description) depends on this example so this should be merged first. My plan now is to try to get the document and examples merged first, then do a follow-up PR for the unit tests and repo-referencing for the code snippets. |
Add listeners
1169201
to
6959868
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ericsnekbytes for the patience
The remaining CI failure is due to the need for the new doc in JupyterLab.
This example shows how to create a dual compatibility extension (for Lab and Notebook) by using optional features, and disabling them when they're not available.