Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error for codemirror-extension example #249

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix type error for codemirror-extension example #249

merged 1 commit into from
Oct 16, 2023

Conversation

firai
Copy link
Contributor

@firai firai commented Oct 14, 2023 •
edited
Loading

Fixes #250

@welcome
Copy link

welcome bot commented Oct 14, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@firai firai changed the title Fix build error for codemirror-extension example Fix type error for codemirror-extension example Oct 15, 2023
@fcollonval fcollonval added the bug Something isn't working label Oct 16, 2023
fcollonval
fcollonval approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @firai

@fcollonval fcollonval merged commit 36a6595 into jupyterlab:main Oct 16, 2023
75 checks passed
@welcome
Copy link

welcome bot commented Oct 16, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@firai firai deleted the fix-cm-ex-type-error branch October 16, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

codemirror-extension example fails to build
2 participants
@firai @fcollonval