-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds config option to use ENTER to send message #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work! In addition to the small comment below, I do have one high-level question that I would like to raise: should we change the default from Shift + Enter
to Enter
? I recall earlier discussion where we had been planning to do this for some time, since chat UIs typically use Enter
to send, in contrast to ours.
I am fine changing the default to |
Per conversation with @ellisonbg , I changed the default to Enter. |
* Adds new config option to swap enter, shift+enter behavior * Updates input, docs * Moves helperText down; removes debug stmts * Combines effects * Sets default behavior to "ENTER sends message" * Change the order to put the new default on top
* Adds new config option to swap enter, shift+enter behavior * Updates input, docs * Moves helperText down; removes debug stmts * Combines effects * Sets default behavior to "ENTER sends message" * Change the order to put the new default on top
Fixes #86.
Adds a config option to swap the uses of Shift+Enter and Enter: the user can choose the default of "Enter sends message" or the alternative of "Shift+Enter sends message":
In the default case, the caption says "Press Shift+Enter to add a new line":
In the alternative case, the caption below the chat box is minimally modified from what you'd see today, "Press Shift+Enter to send message":
Modifies documentation to mention the new default and that users can change the keybindings in the settings pane.