Upgrades openai to version 1, removes openai history in magics #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
force-pushed
the
openai-version
branch
from
6dfdc24 to
6bb2b2d
Compare
JasonWeill
force-pushed
the
openai-version
branch
from
6bb2b2d to
d390f20
Compare
dlqqq
requested changes
Jan 4, 2024
There was a problem hiding this comment.
Thanks for working on this! I left some minor comments for you to address. I think it's perfectly reasonable to drop the transcript/history support for the old OpenAI provider, given that it's no longer maintained, and that it was specific to that provider (violating our design principles). If we want to implement history support in magics again, we should do so in some way irrespective of the model or provider being used.
Let's also make sure to comb through the user documentation and remove any references of our old OpenAI provider supporting history, if any.
for more information, see https://pre-commit.ci
JasonWeill
force-pushed
the
openai-version
branch
from
7c12ee9 to
5c1845b
Compare
JasonWeill
changed the title
dlqqq
requested changes
Jan 5, 2024
|
@meeseeksdev please backport to 1.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
JasonWeill
added a commit
to JasonWeill/jupyter-ai
that referenced
this pull request
Jan 5, 2024
…nai history in magics
JasonWeill
added a commit
that referenced
this pull request
Jan 5, 2024
… openai history in magics)" (#567) * Base chat handler refactor for custom slash commands (#398) * Adds attributes, starts adding to subclasses * Consistent syntax * Help for all handlers * Fix slash ID error * Iterate through entry points * Fix typo in call to select() * Moves config to magics, modifies extensions to attempt to load classes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Moves config to proper location, improves error logging * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * WIP: Updates per feedback, adds custom handler * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removes redundant code, style fixes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removes unnecessary custom message * Instantiates class * Validates slash ID * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Consistent arguments to chat handlers * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactors to avoid intentionally unused params * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates docs, removes custom handler from source and config * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Renames process_message to match base class * Adds needed parameter that had been deleted * Joins lines in contributor doc * Removes natural language routing type, which is not yet used * Update docs/source/developers/index.md Co-authored-by: Piyush Jain <piyushjain@duck.com> * Update docs/source/developers/index.md Co-authored-by: Piyush Jain <piyushjain@duck.com> * Update docs/source/developers/index.md Co-authored-by: Piyush Jain <piyushjain@duck.com> * Revises per @3coins, avoids Latinism * Removes Configurable, since we do not yet have configurable traits * Uses Literal for validation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Piyush Jain <piyushjain@duck.com> (cherry picked from commit 64e6daf) * Backport PR #551: Upgrades openai to version 1, removes openai history in magics
|
Thank you, Jason! What is the release schedule for jupyter-ai? When would the new code be available in 'pip install'? |
|
@simonff Version 2.9.0 is now available in PyPI, so you should be able to upgrade using |
This was referenced Jan 11, 2024
This was referenced Feb 5, 2024
This was referenced May 16, 2024
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
…erlab#551) * Upgrades openai versions * Migration per openai migrate * WIP: Upgrades openai, merges in "new" provider * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * No longer suppress openai-chat * Removes "new" openai-chat provider from commands.ipynb * Suppress warning re custom exception handler * Changes param name to prefix_messages * Renames openai-chat-new model in tests * Removes hard dependency from jupyter-ai on openai, updates magics TOML * Removes "reset" option, copy edits in docs, updates sample file * Removes append_exchange function --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
5 tasks
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
…erlab#551) * Upgrades openai versions * Migration per openai migrate * WIP: Upgrades openai, merges in "new" provider * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * No longer suppress openai-chat * Removes "new" openai-chat provider from commands.ipynb * Suppress warning re custom exception handler * Changes param name to prefix_messages * Renames openai-chat-new model in tests * Removes hard dependency from jupyter-ai on openai, updates magics TOML * Removes "reset" option, copy edits in docs, updates sample file * Removes append_exchange function --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
openaipackage to version 1. Fixes #543.Merges "new" OpenAI provider for magic commands in with the previous "chat" provider.
Removes the history associated uniquely with the
openai-chatprovider in magic commands. Removes the "reset" command to delete said history. Updates the docs to remove mention of the history and the reset command.