Use @jupyterlab/rendermime for in-chat markdown rendering #564

andrii-i · 2024-01-04T07:33:26Z

Use @jupyterlab/rendermime instead of react-markdown for markdown rendering, make code/markdown/math blocks look the same as in JupyterLab
Remove unused dependencies: react-markdown, react-syntax-highlighter, rehype-katex, remark-math. As pointed out by @krassowski, "if I see this right, the package size should drop by 97.7% (over 2 MB) thanks to dropping the extra dependencies (notably react-syntax-highlighter) 🎉"
Escape LaTeX delimeters in LLM responses where needed by adding extra backslashes for proper rendering by @jupyterlab/rendermime
Fixes Improve code styling in markdown #72

RendermimeMarkdown component memoization improves page scripting/rendering speed by ~10% based on performance profiling.

Before:

After:

JasonWeill · 2024-01-05T00:28:55Z

As discussed earlier, the narrow default width of the left panel makes it hard to render code. Perhaps if we move the chat UI to the main area (#76), this will be less of a problem, but for now, Python code straddling multiple lines looks less than ideal:

Options to deal with this include:

Use a hanging indent for Python code lines, for cosmetic appearance, without affecting functionality (see Indent instead of de-indent when soft wrapping long lines in signatures jupyterlab#15561 for a similar request in JupyterLab)
Add horizontal scrolling to the code container

packages/jupyter-ai/style/rendermime-markdown.css

andrii-i · 2024-01-10T21:44:05Z

@JasonWeill, @3coins thank you for looking into this PR, updated it based on your comments and our discussions. It is ready for (re-)review.

packages/jupyter-ai/src/components/copy-button.tsx

andrii-i · 2024-01-25T01:57:36Z

please update playwright snapshots

krassowski

Excited to see this progress! Just some minor suggestions :)

package.json

packages/jupyter-ai/src/index.ts

packages/jupyter-ai/src/components/rendermime-markdown.tsx

krassowski

Two tiny suggestions on dependencies, otherwise it looks great (tested locally).

package.json

packages/jupyter-ai/package.json

krassowski

The lockfile may still need updating (not sure about your internal rebase practices), but otherwise it looks good to me.

PS. If I see this right, the package size should drop by 97.7% (over 2 MB) thanks to dropping the extra dependencies (notably react-syntax-highlighter) 🎉

dlqqq

@andrii-i This is awesome work! The new UI is much cleaner and noticeably faster. Just a few minor concerns, but this is 95% ready to ship. 🎉

packages/jupyter-ai/src/components/rendermime-markdown.tsx

packages/jupyter-ai/package.json

packages/jupyter-ai/src/components/rendermime-markdown.tsx

andrii-i · 2024-02-07T23:14:04Z

Thank you @dlqqq. All comments are implemented.

… redefinitions on every rerender

Co-authored-by: david qiu <david@qiu.dev>

… potential build errors

andrii-i · 2024-02-08T01:42:23Z

@meeseeksdev please backport to 1.x

lumberbot-app · 2024-02-08T01:43:11Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

git checkout 1.x
git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 a6868ffc245e098c165399e43bb8b248fa575abd

You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #564: Use @jupyterlab/rendermime for in-chat markdown rendering'

Push to a named branch:

git push YOURFORK 1.x:auto-backport-of-pr-564-on-1.x

Create a PR against branch 1.x, I would have named this PR:

"Backport PR #564 on branch 1.x (Use @jupyterlab/rendermime for in-chat markdown rendering)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@dlqqq

…#564) * create markdown widget and component * add rendermime * add rendermime registry requrement, activation to plugin * update var naming * use rendermime directrly in the react component * use css to emulate code styling * add @types/react-dom * create CopyButton component based on chat-code-view.tsx by @dlqqq * add CopyButton and styling * remoev unsused code * add min width to the button * omit units for 0 * use RendermimeMarkdown for ChatSettings model help * remove react-markdown dependency * revert CopyButton styling * remove comments * memoize RendermimeMarkdown (10% faster) * Update packages/jupyter-ai/src/components/copy-button.tsx Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * remove copying status * update yarn.lock * detect mimetype, render latex * set latexTypesetter * MathJax typeset redered md * use rmRegistry typesetter * remove MathJaxTypesetter import * Modify CHAT_SYSTEM_PROMPT, use $ and $$ style LaTeX delimiters only * remove @jupyterlab/mathjax-extension dependency * remove @jupyterlab/builder dependency * Update packages/jupyter-ai/src/index.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * render content after attaching buttons per @krassowski * remove duplicate rmRegistry per @krassowski * update snapshots * Remove unused react-syntax-highlighter, rehype-katex, remark-math dependencies * move @types/react-dom dependency from root to packages/jupyter-ai per @krassowski * Update packages/jupyter-ai/package.json Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * update yarn.lock * Escale LaTeX delimeters with regex instead of prompt engineering * add .jp-ai-rendermime-markdown mjx-container styling to match jlab * update escapeLatexDelimiters comment * update lockfile * update lockfile * move escapeLatexDelimiters outside of RendermimeMarkdownBase to avoid redefinitions on every rerender * adjust escapeLatexDelimiters parameter naming * Rename escapeLatexDelimiters argument from str to text * Update packages/jupyter-ai/src/components/rendermime-markdown.tsx Co-authored-by: david qiu <david@qiu.dev> * Update escapeLatexDelimiters docstring per @dlqqq * bump react-dom version per @dlqqq * add @jupyterlab/rendermime as a direct dependenct per @dlqqq to avoid potential build errors --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: david qiu <david@qiu.dev>

@dlqqq

…#564) * create markdown widget and component * add rendermime * add rendermime registry requrement, activation to plugin * update var naming * use rendermime directrly in the react component * use css to emulate code styling * add @types/react-dom * create CopyButton component based on chat-code-view.tsx by @dlqqq * add CopyButton and styling * remoev unsused code * add min width to the button * omit units for 0 * use RendermimeMarkdown for ChatSettings model help * remove react-markdown dependency * revert CopyButton styling * remove comments * memoize RendermimeMarkdown (10% faster) * Update packages/jupyter-ai/src/components/copy-button.tsx Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * remove copying status * update yarn.lock * detect mimetype, render latex * set latexTypesetter * MathJax typeset redered md * use rmRegistry typesetter * remove MathJaxTypesetter import * Modify CHAT_SYSTEM_PROMPT, use $ and $$ style LaTeX delimiters only * remove @jupyterlab/mathjax-extension dependency * remove @jupyterlab/builder dependency * Update packages/jupyter-ai/src/index.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * render content after attaching buttons per @krassowski * remove duplicate rmRegistry per @krassowski * update snapshots * Remove unused react-syntax-highlighter, rehype-katex, remark-math dependencies * move @types/react-dom dependency from root to packages/jupyter-ai per @krassowski * Update packages/jupyter-ai/package.json Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * update yarn.lock * Escale LaTeX delimeters with regex instead of prompt engineering * add .jp-ai-rendermime-markdown mjx-container styling to match jlab * update escapeLatexDelimiters comment * update lockfile * update lockfile * move escapeLatexDelimiters outside of RendermimeMarkdownBase to avoid redefinitions on every rerender * adjust escapeLatexDelimiters parameter naming * Rename escapeLatexDelimiters argument from str to text * Update packages/jupyter-ai/src/components/rendermime-markdown.tsx Co-authored-by: david qiu <david@qiu.dev> * Update escapeLatexDelimiters docstring per @dlqqq * bump react-dom version per @dlqqq * add @jupyterlab/rendermime as a direct dependenct per @dlqqq to avoid potential build errors --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: david qiu <david@qiu.dev>

@dlqqq

…#564) * create markdown widget and component * add rendermime * add rendermime registry requrement, activation to plugin * update var naming * use rendermime directrly in the react component * use css to emulate code styling * add @types/react-dom * create CopyButton component based on chat-code-view.tsx by @dlqqq * add CopyButton and styling * remoev unsused code * add min width to the button * omit units for 0 * use RendermimeMarkdown for ChatSettings model help * remove react-markdown dependency * revert CopyButton styling * remove comments * memoize RendermimeMarkdown (10% faster) * Update packages/jupyter-ai/src/components/copy-button.tsx Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * remove copying status * update yarn.lock * detect mimetype, render latex * set latexTypesetter * MathJax typeset redered md * use rmRegistry typesetter * remove MathJaxTypesetter import * Modify CHAT_SYSTEM_PROMPT, use $ and $$ style LaTeX delimiters only * remove @jupyterlab/mathjax-extension dependency * remove @jupyterlab/builder dependency * Update packages/jupyter-ai/src/index.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * render content after attaching buttons per @krassowski * remove duplicate rmRegistry per @krassowski * update snapshots * Remove unused react-syntax-highlighter, rehype-katex, remark-math dependencies * move @types/react-dom dependency from root to packages/jupyter-ai per @krassowski * Update packages/jupyter-ai/package.json Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * update yarn.lock * Escale LaTeX delimeters with regex instead of prompt engineering * add .jp-ai-rendermime-markdown mjx-container styling to match jlab * update escapeLatexDelimiters comment * update lockfile * update lockfile * move escapeLatexDelimiters outside of RendermimeMarkdownBase to avoid redefinitions on every rerender * adjust escapeLatexDelimiters parameter naming * Rename escapeLatexDelimiters argument from str to text * Update packages/jupyter-ai/src/components/rendermime-markdown.tsx Co-authored-by: david qiu <david@qiu.dev> * Update escapeLatexDelimiters docstring per @dlqqq * bump react-dom version per @dlqqq * add @jupyterlab/rendermime as a direct dependenct per @dlqqq to avoid potential build errors --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: david qiu <david@qiu.dev>

@dlqqq

…#564) * create markdown widget and component * add rendermime * add rendermime registry requrement, activation to plugin * update var naming * use rendermime directrly in the react component * use css to emulate code styling * add @types/react-dom * create CopyButton component based on chat-code-view.tsx by @dlqqq * add CopyButton and styling * remoev unsused code * add min width to the button * omit units for 0 * use RendermimeMarkdown for ChatSettings model help * remove react-markdown dependency * revert CopyButton styling * remove comments * memoize RendermimeMarkdown (10% faster) * Update packages/jupyter-ai/src/components/copy-button.tsx Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * remove copying status * update yarn.lock * detect mimetype, render latex * set latexTypesetter * MathJax typeset redered md * use rmRegistry typesetter * remove MathJaxTypesetter import * Modify CHAT_SYSTEM_PROMPT, use $ and $$ style LaTeX delimiters only * remove @jupyterlab/mathjax-extension dependency * remove @jupyterlab/builder dependency * Update packages/jupyter-ai/src/index.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * render content after attaching buttons per @krassowski * remove duplicate rmRegistry per @krassowski * update snapshots * Remove unused react-syntax-highlighter, rehype-katex, remark-math dependencies * move @types/react-dom dependency from root to packages/jupyter-ai per @krassowski * Update packages/jupyter-ai/package.json Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * update yarn.lock * Escale LaTeX delimeters with regex instead of prompt engineering * add .jp-ai-rendermime-markdown mjx-container styling to match jlab * update escapeLatexDelimiters comment * update lockfile * update lockfile * move escapeLatexDelimiters outside of RendermimeMarkdownBase to avoid redefinitions on every rerender * adjust escapeLatexDelimiters parameter naming * Rename escapeLatexDelimiters argument from str to text * Update packages/jupyter-ai/src/components/rendermime-markdown.tsx Co-authored-by: david qiu <david@qiu.dev> * Update escapeLatexDelimiters docstring per @dlqqq * bump react-dom version per @dlqqq * add @jupyterlab/rendermime as a direct dependenct per @dlqqq to avoid potential build errors --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: david qiu <david@qiu.dev>

@dlqqq

* Use @jupyterlab/rendermime for in-chat markdown rendering (#564) * create markdown widget and component * add rendermime * add rendermime registry requrement, activation to plugin * update var naming * use rendermime directrly in the react component * use css to emulate code styling * add @types/react-dom * create CopyButton component based on chat-code-view.tsx by @dlqqq * add CopyButton and styling * remoev unsused code * add min width to the button * omit units for 0 * use RendermimeMarkdown for ChatSettings model help * remove react-markdown dependency * revert CopyButton styling * remove comments * memoize RendermimeMarkdown (10% faster) * Update packages/jupyter-ai/src/components/copy-button.tsx Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * remove copying status * update yarn.lock * detect mimetype, render latex * set latexTypesetter * MathJax typeset redered md * use rmRegistry typesetter * remove MathJaxTypesetter import * Modify CHAT_SYSTEM_PROMPT, use $ and $$ style LaTeX delimiters only * remove @jupyterlab/mathjax-extension dependency * remove @jupyterlab/builder dependency * Update packages/jupyter-ai/src/index.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * render content after attaching buttons per @krassowski * remove duplicate rmRegistry per @krassowski * update snapshots * Remove unused react-syntax-highlighter, rehype-katex, remark-math dependencies * move @types/react-dom dependency from root to packages/jupyter-ai per @krassowski * Update packages/jupyter-ai/package.json Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * update yarn.lock * Escale LaTeX delimeters with regex instead of prompt engineering * add .jp-ai-rendermime-markdown mjx-container styling to match jlab * update escapeLatexDelimiters comment * update lockfile * update lockfile * move escapeLatexDelimiters outside of RendermimeMarkdownBase to avoid redefinitions on every rerender * adjust escapeLatexDelimiters parameter naming * Rename escapeLatexDelimiters argument from str to text * Update packages/jupyter-ai/src/components/rendermime-markdown.tsx Co-authored-by: david qiu <david@qiu.dev> * Update escapeLatexDelimiters docstring per @dlqqq * bump react-dom version per @dlqqq * add @jupyterlab/rendermime as a direct dependenct per @dlqqq to avoid potential build errors --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: david qiu <david@qiu.dev> * Add "@jupyterlab/rendermime": "^3.6.3" dependency --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: david qiu <david@qiu.dev>

krassowski · 2024-03-06T17:23:18Z

Thanks to this PR the tarball size dropped by 1.5MB 🎉

Before	After

@dlqqq

…#564) * create markdown widget and component * add rendermime * add rendermime registry requrement, activation to plugin * update var naming * use rendermime directrly in the react component * use css to emulate code styling * add @types/react-dom * create CopyButton component based on chat-code-view.tsx by @dlqqq * add CopyButton and styling * remoev unsused code * add min width to the button * omit units for 0 * use RendermimeMarkdown for ChatSettings model help * remove react-markdown dependency * revert CopyButton styling * remove comments * memoize RendermimeMarkdown (10% faster) * Update packages/jupyter-ai/src/components/copy-button.tsx Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * remove copying status * update yarn.lock * detect mimetype, render latex * set latexTypesetter * MathJax typeset redered md * use rmRegistry typesetter * remove MathJaxTypesetter import * Modify CHAT_SYSTEM_PROMPT, use $ and $$ style LaTeX delimiters only * remove @jupyterlab/mathjax-extension dependency * remove @jupyterlab/builder dependency * Update packages/jupyter-ai/src/index.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * render content after attaching buttons per @krassowski * remove duplicate rmRegistry per @krassowski * update snapshots * Remove unused react-syntax-highlighter, rehype-katex, remark-math dependencies * move @types/react-dom dependency from root to packages/jupyter-ai per @krassowski * Update packages/jupyter-ai/package.json Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * update yarn.lock * Escale LaTeX delimeters with regex instead of prompt engineering * add .jp-ai-rendermime-markdown mjx-container styling to match jlab * update escapeLatexDelimiters comment * update lockfile * update lockfile * move escapeLatexDelimiters outside of RendermimeMarkdownBase to avoid redefinitions on every rerender * adjust escapeLatexDelimiters parameter naming * Rename escapeLatexDelimiters argument from str to text * Update packages/jupyter-ai/src/components/rendermime-markdown.tsx Co-authored-by: david qiu <david@qiu.dev> * Update escapeLatexDelimiters docstring per @dlqqq * bump react-dom version per @dlqqq * add @jupyterlab/rendermime as a direct dependenct per @dlqqq to avoid potential build errors --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: david qiu <david@qiu.dev>

@dlqqq

…#564) * create markdown widget and component * add rendermime * add rendermime registry requrement, activation to plugin * update var naming * use rendermime directrly in the react component * use css to emulate code styling * add @types/react-dom * create CopyButton component based on chat-code-view.tsx by @dlqqq * add CopyButton and styling * remoev unsused code * add min width to the button * omit units for 0 * use RendermimeMarkdown for ChatSettings model help * remove react-markdown dependency * revert CopyButton styling * remove comments * memoize RendermimeMarkdown (10% faster) * Update packages/jupyter-ai/src/components/copy-button.tsx Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * remove copying status * update yarn.lock * detect mimetype, render latex * set latexTypesetter * MathJax typeset redered md * use rmRegistry typesetter * remove MathJaxTypesetter import * Modify CHAT_SYSTEM_PROMPT, use $ and $$ style LaTeX delimiters only * remove @jupyterlab/mathjax-extension dependency * remove @jupyterlab/builder dependency * Update packages/jupyter-ai/src/index.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * render content after attaching buttons per @krassowski * remove duplicate rmRegistry per @krassowski * update snapshots * Remove unused react-syntax-highlighter, rehype-katex, remark-math dependencies * move @types/react-dom dependency from root to packages/jupyter-ai per @krassowski * Update packages/jupyter-ai/package.json Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * update yarn.lock * Escale LaTeX delimeters with regex instead of prompt engineering * add .jp-ai-rendermime-markdown mjx-container styling to match jlab * update escapeLatexDelimiters comment * update lockfile * update lockfile * move escapeLatexDelimiters outside of RendermimeMarkdownBase to avoid redefinitions on every rerender * adjust escapeLatexDelimiters parameter naming * Rename escapeLatexDelimiters argument from str to text * Update packages/jupyter-ai/src/components/rendermime-markdown.tsx Co-authored-by: david qiu <david@qiu.dev> * Update escapeLatexDelimiters docstring per @dlqqq * bump react-dom version per @dlqqq * add @jupyterlab/rendermime as a direct dependenct per @dlqqq to avoid potential build errors --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: david qiu <david@qiu.dev>

andrii-i added the enhancement New feature or request label Jan 4, 2024

andrii-i force-pushed the use-rendermime-markdown branch from 15d6fc8 to bc1807f Compare January 4, 2024 07:33

andrii-i force-pushed the use-rendermime-markdown branch 2 times, most recently from 9eefaf8 to 4325658 Compare January 9, 2024 07:06

3coins reviewed Jan 10, 2024

View reviewed changes

packages/jupyter-ai/style/rendermime-markdown.css Show resolved Hide resolved

andrii-i marked this pull request as ready for review January 10, 2024 21:43

andrii-i force-pushed the use-rendermime-markdown branch from 3bcfb93 to a3dba7a Compare January 10, 2024 23:26

JasonWeill reviewed Jan 11, 2024

View reviewed changes

packages/jupyter-ai/src/components/copy-button.tsx Outdated Show resolved Hide resolved

dlqqq mentioned this pull request Jan 11, 2024

fix MUI text theme #200

Closed

andrii-i force-pushed the use-rendermime-markdown branch from adc8737 to fc679ac Compare January 25, 2024 01:05

krassowski reviewed Jan 31, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

packages/jupyter-ai/src/index.ts Outdated Show resolved Hide resolved

packages/jupyter-ai/src/components/rendermime-markdown.tsx Outdated Show resolved Hide resolved

krassowski reviewed Feb 2, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

packages/jupyter-ai/package.json Outdated Show resolved Hide resolved

andrii-i force-pushed the use-rendermime-markdown branch from 879ad79 to 363ba1a Compare February 2, 2024 23:27

krassowski reviewed Feb 3, 2024

View reviewed changes

packages/jupyter-ai/package.json Outdated Show resolved Hide resolved

krassowski approved these changes Feb 3, 2024

View reviewed changes

andrii-i force-pushed the use-rendermime-markdown branch 2 times, most recently from 41fc575 to 9cab65c Compare February 6, 2024 19:07

dlqqq self-assigned this Feb 6, 2024

dlqqq self-requested a review February 6, 2024 19:25

andrii-i force-pushed the use-rendermime-markdown branch 3 times, most recently from a748e32 to fd56bbe Compare February 7, 2024 19:42

dlqqq requested changes Feb 7, 2024

View reviewed changes

andrii-i force-pushed the use-rendermime-markdown branch from ad0ba1b to 656e851 Compare February 7, 2024 22:21

andrii-i requested a review from dlqqq February 7, 2024 23:12

create markdown widget and component

f508d7d

andrii-i and others added 12 commits February 7, 2024 15:39

Escale LaTeX delimeters with regex instead of prompt engineering

ae1a0b7

add .jp-ai-rendermime-markdown mjx-container styling to match jlab

7bbc099

update escapeLatexDelimiters comment

affd353

update lockfile

1d69280

update lockfile

35c6377

move escapeLatexDelimiters outside of RendermimeMarkdownBase to avoid…

ac74941

… redefinitions on every rerender

adjust escapeLatexDelimiters parameter naming

bfdf488

Rename escapeLatexDelimiters argument from str to text

b692679

Update packages/jupyter-ai/src/components/rendermime-markdown.tsx

2a8a680

Co-authored-by: david qiu <david@qiu.dev>

Update escapeLatexDelimiters docstring per @dlqqq

8578990

bump react-dom version per @dlqqq

b257a9d

add @jupyterlab/rendermime as a direct dependenct per @dlqqq to avoid…

748fd38

… potential build errors

dlqqq force-pushed the use-rendermime-markdown branch from 128f8b2 to 748fd38 Compare February 7, 2024 23:39

dlqqq approved these changes Feb 7, 2024

View reviewed changes

andrii-i enabled auto-merge (squash) February 7, 2024 23:42

andrii-i merged commit a6868ff into jupyterlab:main Feb 7, 2024
8 checks passed

andrii-i deleted the use-rendermime-markdown branch February 7, 2024 23:50

lumberbot-app bot added the Still Needs Manual Backport label Feb 8, 2024

andrii-i mentioned this pull request Feb 8, 2024

[1.x] Use @jupyterlab/rendermime for in-chat markdown rendering #631

Merged

andrii-i removed the Still Needs Manual Backport label Feb 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use @jupyterlab/rendermime for in-chat markdown rendering #564

Use @jupyterlab/rendermime for in-chat markdown rendering #564

andrii-i commented Jan 4, 2024 •

edited

Loading

JasonWeill commented Jan 5, 2024

andrii-i commented Jan 10, 2024

andrii-i commented Jan 25, 2024

krassowski left a comment

krassowski left a comment

krassowski left a comment

dlqqq left a comment

andrii-i commented Feb 7, 2024

andrii-i commented Feb 8, 2024

lumberbot-app bot commented Feb 8, 2024

krassowski commented Mar 6, 2024

Use @jupyterlab/rendermime for in-chat markdown rendering #564

Use @jupyterlab/rendermime for in-chat markdown rendering #564

Conversation

andrii-i commented Jan 4, 2024 • edited Loading

JasonWeill commented Jan 5, 2024

andrii-i commented Jan 10, 2024

andrii-i commented Jan 25, 2024

krassowski left a comment

Choose a reason for hiding this comment

krassowski left a comment

Choose a reason for hiding this comment

krassowski left a comment

Choose a reason for hiding this comment

dlqqq left a comment

Choose a reason for hiding this comment

andrii-i commented Feb 7, 2024

andrii-i commented Feb 8, 2024

lumberbot-app bot commented Feb 8, 2024

krassowski commented Mar 6, 2024

andrii-i commented Jan 4, 2024 •

edited

Loading