Update chat handling to clear chat and show help; small fix to /export
#826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) Make sure to use the `chat_history` prefix in the filename if none is supplied and not use a blank string on double `<Enter>` (2) When using `/clear` clear the entire chat but show the help menu.
for more information, see https://pre-commit.ci
dlqqq
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
@srdas Thank you! This PR works for me locally.
If the user changes their configured language model to one with a custom persona, this will show the old help message with the old persona instead of the new one. However, there are already plans to clear the chat message history entirely when the language model persona changes, so this issue can be addressed in a future PR.
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
…rt` (jupyterlab#826) * Update chat handling (1) Make sure to use the `chat_history` prefix in the filename if none is supplied and not use a blank string on double `<Enter>` (2) When using `/clear` clear the entire chat but show the help menu. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Make sure to use the
chat_historyprefix in the filename if none is supplied and not use a blank string on double<Enter>. Currently the double<Enter>after/exportputs an empty filename prefix as follows:After the fix we get:
(2) When using
/clear, clear the entire chat but show the help menu afterwards.Related to #616 but will clear memory in a separate PR.