Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include jlpm within this package #15

Closed
fcollonval opened this issue Jul 5, 2024 · 0 comments · Fixed by #20
Closed

Include jlpm within this package #15

fcollonval opened this issue Jul 5, 2024 · 0 comments · Fixed by #20
Labels
enhancement New feature or request

Comments

@fcollonval
Copy link
Member

We should add jlpm within this package rather than jupyterlab.

For now, jlpm define there: https://github.com/jupyterlab/jupyterlab/blob/main/jupyterlab/jlpmapp.py
with the entrypoint defined there: https://github.com/jupyterlab/jupyterlab/blob/e048f27548969c0e4403417ac04bc186f119128f/pyproject.toml#L60
@fcollonval fcollonval added the enhancement New feature or request label Jul 5, 2024
@fcollonval fcollonval mentioned this issue Jul 19, 2024
Merged
fcollonval added a commit that referenced this issue Jul 26, 2024
@cronan03 @fcollonval @github-actions
Include jlpm within this package (Issue #15) (#20)
f8445bd 
* watch working

* watch test working

* Update jupyter_builder/extension_commands/watch.py

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>

* Update jupyter_builder/federated_extensions.py

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>

* sleep time increased in test

* Automatic application of license header

* Delete jupyter_builder/yarn.js

* ran precommit

* added jlpm

* Automatic application of license header

* yarn exclude

* exclude

* Update .licenserc.yaml

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>

* Update .pre-commit-config.yaml

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>

* remove folder

* linter

---------

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include jlpm within this package (Issue #15) cronan03/jupyterlab-builder
1 participant
@fcollonval