Improve (and fix) unread messages and navigation #443
brichetbuild.yml
on: pull_request
Build jupyter_chat
2m 55s
Typing test
2m 23s
Check Links
58s
Python test on extensions
2m 16s
Integration tests
8m 15s
Integration tests notebook
1m 31s
Annotations
10 errors, 8 warnings, and 2 notices
|
tests/chat-file.spec.ts:96:7 › #chatCreation › should create a chat in default directory and keep not empty directory:
ui-tests/tests/chat-file.spec.ts#L120
1) tests/chat-file.spec.ts:96:7 › #chatCreation › should create a chat in default directory and keep not empty directory
Error: expect(received).toBeTruthy()
Received: false
118 | PathExt.join(CHAT_DIR, FILENAME)
119 | )
> 120 | ).toBeTruthy();
| ^
121 |
122 | // Reactivate settings panel
123 | await openSettings(page);
at /home/runner/work/jupyter-chat/jupyter-chat/ui-tests/tests/chat-file.spec.ts:120:7
|
|
tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata:
ui-tests/tests/chat-file.spec.ts#L1
2) tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata ────────────────
Test timeout of 60000ms exceeded.
|
|
tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata:
ui-tests/http:/localhost:8888/static/lab/jlab_core.65f3a9357549aad3de7f.js?v=65f3a9357549aad3de7f#L1
2) tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata ────────────────
Error: proxy.evaluate: Error: Invalid response: 404 Not Found
at i.create (http://localhost:8888/static/lab/jlab_core.65f3a9357549aad3de7f.js?v=65f3a9357549aad3de7f:1:1432099)
at async m.get (http://localhost:8888/static/lab/jlab_core.65f3a9357549aad3de7f.js?v=65f3a9357549aad3de7f:1:1376888)
at async eval (eval at evaluate (:226:30), <anonymous>:2:12)
at async <anonymous>:252:30
at i.create (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/http:/localhost:8888/static/lab/jlab_core.65f3a9357549aad3de7f.js?v=65f3a9357549aad3de7f:1:1432099)
at async m.get (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/http:/localhost:8888/static/lab/jlab_core.65f3a9357549aad3de7f.js?v=65f3a9357549aad3de7f:1:1376888)
at async eval (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/eval at evaluate (:226:30), <anonymous>:2:12)
at /home/runner/work/jupyter-chat/jupyter-chat/ui-tests/async <anonymous>:252:30
at readFileContent (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/tests/chat-file.spec.ts:32:21)
at hasId (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/tests/chat-file.spec.ts:173:27)
at Timeout.check (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:183:33)
|
|
tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message:
ui-tests/tests/notifications.spec.ts#L1
3) tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message
Test timeout of 60000ms exceeded.
|
|
tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message:
ui-tests/tests/test-utils.ts#L50
3) tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message
Error: locator.isChecked: Target page, context or browser has been closed
at tests/test-utils.ts:50
48 | const tabName = splitPath[splitPath.length - 1];
49 | await page.waitForCondition(
> 50 | async () => await page.activity.isTabActive(tabName)
| ^
51 | );
52 | return (await page.activity.getPanelLocator(tabName)) as Locator;
53 | };
at Object.isInSimpleMode (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:311:17)
at ActivityHelper.isTabActive (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/node_modules/@jupyterlab/galata/src/helpers/activity.ts:46:21)
at /home/runner/work/jupyter-chat/jupyter-chat/ui-tests/tests/test-utils.ts:50:37
at Timeout.check (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:183:33)
|
|
tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message:
ui-tests/tests/notifications.spec.ts#L1
3) tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded.
|
|
tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message:
ui-tests/tests/test-utils.ts#L50
3) tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.isChecked: Target page, context or browser has been closed
at tests/test-utils.ts:50
48 | const tabName = splitPath[splitPath.length - 1];
49 | await page.waitForCondition(
> 50 | async () => await page.activity.isTabActive(tabName)
| ^
51 | );
52 | return (await page.activity.getPanelLocator(tabName)) as Locator;
53 | };
at Object.isInSimpleMode (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:311:17)
at ActivityHelper.isTabActive (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/node_modules/@jupyterlab/galata/src/helpers/activity.ts:46:21)
at /home/runner/work/jupyter-chat/jupyter-chat/ui-tests/tests/test-utils.ts:50:37
at Timeout.check (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:183:33)
|
|
tests/notifications.spec.ts:111:7 › #notifications › should remove notification when the message is read:
ui-tests/tests/notifications.spec.ts#L118
4) tests/notifications.spec.ts:111:7 › #notifications › should remove notification when the message is read
Error: locator.scrollIntoViewIfNeeded: Element is not attached to the DOM
Call log:
- attempting scroll into view action
- waiting for element to be stable
116 |
117 | // Navigate to the last to set all messages as read.
> 118 | await messages.last().scrollIntoViewIfNeeded();
| ^
119 |
120 | await messages.first().scrollIntoViewIfNeeded();
121 |
at /home/runner/work/jupyter-chat/jupyter-chat/ui-tests/tests/notifications.spec.ts:118:27
|
|
tests/ui-config.spec.ts:217:7 › #typingNotification › should not display typing users if disabled:
ui-tests/tests/ui-config.spec.ts#L251
5) tests/ui-config.spec.ts:217:7 › #typingNotification › should not display typing users if disabled
Error: The typing notification should not be attached.
249 |
250 | if (visible) {
> 251 | throw Error('The typing notification should not be attached.');
| ^
252 | }
253 | });
254 |
at /home/runner/work/jupyter-chat/jupyter-chat/ui-tests/tests/ui-config.spec.ts:251:13
|
|
tests/ui-config.spec.ts:217:7 › #typingNotification › should not display typing users if disabled:
ui-tests/tests/ui-config.spec.ts#L245
5) tests/ui-config.spec.ts:217:7 › #typingNotification › should not display typing users if disabled
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.isVisible: Target page, context or browser has been closed
243 | let visible = true;
244 | try {
> 245 | await page.waitForCondition(() => writers.isVisible(), 3000);
| ^
246 | } catch {
247 | visible = false;
248 | }
at /home/runner/work/jupyter-chat/jupyter-chat/ui-tests/tests/ui-config.spec.ts:245:49
at Timeout.check (/home/runner/work/jupyter-chat/jupyter-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:183:33)
|
|
Check Links
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Build jupyter_chat
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Typing test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Build chat extension
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Python test on extensions
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Integration tests notebook
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Integration tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "jupyterlab_chat-artifacts", "jupyterlab_chat-notebook-playwright-tests", "jupyterlab_chat-playwright-tests".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
|
🎭 Playwright Run Summary
2 passed (12.2s)
|
|
🎭 Playwright Run Summary
6 flaky
tests/chat-file.spec.ts:96:7 › #chatCreation › should create a chat in default directory and keep not empty directory
tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata ─────────────────
tests/notifications.spec.ts:89:7 › #notifications › should receive notification on unread message
tests/notifications.spec.ts:111:7 › #notifications › should remove notification when the message is read
tests/ui-config.spec.ts:217:7 › #typingNotification › should not display typing users if disabled
tests/unread.spec.ts:56:9 › #messagesNavigation › navigation without unread message › should navigate to last message
2 skipped
80 passed (7.0m)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
jupyterlab_chat-artifacts
|
1.68 MB |
|
|
jupyterlab_chat-notebook-playwright-tests
|
436 KB |
|
|
jupyterlab_chat-playwright-tests
|
37.9 MB |
|