Adds restore and ovewrite messages #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hbcarlos
force-pushed
the
rtc-subprotocol
branch
from
26349a8 to
50f9c43
Compare
davidbrochart
added a commit
to davidbrochart/jupyter_collaboration
that referenced
this pull request
Dec 26, 2023
davidbrochart
added a commit
to davidbrochart/jupyter_collaboration
that referenced
this pull request
Dec 26, 2023
davidbrochart
added a commit
to davidbrochart/jupyter_collaboration
that referenced
this pull request
Dec 26, 2023
davidbrochart
added a commit
that referenced
this pull request
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
Watching the file doesn't stop because multiple rooms could access the same file.
I added a lock so the room stops sending the message until the user responds.
Any user can answer the message.
We must keep track of the messages to dismiss other users' answers or close the dialog.
I created a dictionary of locks to tackle this.
When opening the same file with different views in the same lab instance, the dialog pops up whenever you modify the document.
Should this feature be optional?