Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #182

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Tests #182

merged 6 commits into from
Sep 6, 2023

Conversation

hbcarlos
Copy link
Member

@hbcarlos hbcarlos commented Aug 8, 2023 •
edited
Loading

Creates a test suit for rtc and improves the tests.

TODO:

  • Add fixtures to create files and add them to the store
  • Add fixtures to connect clients
  • Add helpers to send room messages
  • Add tests for settings
  • Test DocSessionHandler
  • Test YDocWebSocketHandler
  • Test initialization of rooms
  • Test room messages

Todo on a follow-up PR:

  • Test disable_rtc
  • Add helpers to check the content in the store
  • Test stores

@hbcarlos hbcarlos self-assigned this Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Binder 👈 Launch a Binder on branch hbcarlos/jupyter-collaboration/rtc-tests

@hbcarlos hbcarlos marked this pull request as ready for review August 8, 2023 16:01
@hbcarlos hbcarlos force-pushed the rtc-tests branch 2 times, most recently from b37b1c2 to 3f1f6d3 Compare August 10, 2023 13:39
@hbcarlos
Copy link
Member Author

The PyPy test fails because of jupyter-server/jupyter_server_fileid#44

Commenting the PyPy job for now.

@hbcarlos hbcarlos requested a review from fcollonval August 10, 2023 14:19
fcollonval
fcollonval approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@fcollonval fcollonval merged commit 830ee61 into jupyterlab:main Sep 6, 2023
@hbcarlos hbcarlos deleted the rtc-tests branch September 7, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@hbcarlos hbcarlos

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbcarlos @fcollonval