-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add winget publish github action #647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, there are 2 things that need to be done:
- Please add a GitHub token with
public_repo
andworkflow
scopes as a repository secret and rename the secret name in the workflow. - Fork microsoft/winget-pkgs under @jupyterlab.
It is not ideal for us to fork microsoft/winget-pkgs under https://github.com/jupyterlab. we were expecting someone from community to update winget-pkgs repo as needed. It appears publishing winget package will require us to maintain it. any thoughts @krassowski? |
@mbektas if that's the case, then any maintainer can fork winget-pkgs repo under their personal account and the workflow will be updated accordingly. |
I think we can keep a fork under a bot account, the fork location appears customisable as per https://github.com/vedantmgoyal2009/winget-releaser#use-fork-under-which-user-fork-user.
If this is running on CI with minimal maintianer intervention I would be fine to proceed. However, I am a bit concerned with using There is another, simpler way to handle this without a CI action on our side nor a fork, by using a "vanity URL" as per microsoft/winget-pkgs#500 (comment). We are already discussing a possibility of using vanity URLs in jupyterlab/jupyterlab#14675 (comment) (CC @fcollonval, @paddymul) so maybe having a vanity URL per OS and one catch-all coud be the way to go. |
@brl0 @vedantmgoyal9 thanks for the contribution, I will merge and wrap it up. |
This adds a github action to publish the windows version to the winget-pkgs repo. The winget-releaser github action requires a personal token as
WINGET_TOKEN
. Details for configuration are here: https://github.com/vedantmgoyal2009/winget-releaserFor now, I have also submitted a PR to winget-pkgs to update to the current version, using the underlying tool utilized by this action.
This is my first attempt at configuring this as an action, so please let me know if there are any questions, concerns, or issues.
Thanks!