Skip processing svg anchor elements #5610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Also fixes #5610
Fixes #5589 by skipping
processing of a elements that are not
HTMLAnchorElement
s, includingthose within SVG elements. Currently, if you have a
a
elementinside an SVG element it will break HTML rendering since that element
does not have a
href
like othera
elements do.Screenshots
Before, this code (from issue #5589) will end up raising an exception while rendering and so will display no output:
After, this exception will not be raised since we skip processing the
a
elements in thesvg
element and so it will render correctly, as it does in Jupyter Notebook