Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix running cell when focused on output #10517

Merged
merged 1 commit into from
Jun 30, 2021
Merged

fix running cell when focused on output #10517

merged 1 commit into from
Jun 30, 2021

Conversation

cameron-toy
Copy link
Contributor

References

Running cell focused on output broken in 3.1.0a13 #10429

Code changes

Permanently added data-jp-code-runner attribute to notebook.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added the bug label Jun 30, 2021
@blink1073 blink1073 added this to the 3.1 milestone Jun 30, 2021
blink1073
blink1073 approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Test failures are unrelated

@blink1073 blink1073 merged commit 671fc2d into jupyterlab:master Jun 30, 2021
@krassowski krassowski mentioned this pull request Jul 9, 2021
Closed
@krassowski krassowski mentioned this pull request Jul 20, 2021
Closed
krassowski added a commit to krassowski/jupyterlab that referenced this pull request Jul 20, 2021
@krassowski
Restore the focus target check removed in jupyterlab#10517
5563b62
@krassowski krassowski mentioned this pull request Jul 20, 2021
Merged
krassowski added a commit to krassowski/jupyterlab that referenced this pull request Jul 20, 2021
@krassowski
Restore the focus target check removed in jupyterlab#10517
66e725f
@krassowski krassowski mentioned this pull request Jul 20, 2021
Closed
blink1073 pushed a commit that referenced this pull request Jul 21, 2021
@krassowski
Restore the focus target check removed in #10517 (#10664)
98edcbd 
* Restore the focus target check removed in #10517

* Update reference outputs
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jul 21, 2021
@krassowski @meeseeksmachine
Backport PR jupyterlab#10664: Restore the focus target check removed in
8c7b493 
jupyterlab#10517
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 21, 2021
Merged
blink1073 pushed a commit that referenced this pull request Jul 21, 2021
@meeseeksmachine @krassowski
Backport PR #10664: Restore the focus target check removed in #10517 (#…
d537941 
…10665)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Dec 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

@cameron-toy cameron-toy

Labels
bug pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cameron-toy @blink1073