Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabIndex taking focus away from notebook #10580

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

krassowski
Copy link
Member

References

Fixes #10566.

Code changes

Remove tabIndex added in #10282.

User-facing changes

Cell operations work consistently again.

Backwards-incompatible changes

None.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@krassowski krassowski added this to the 3.1 milestone Jul 8, 2021
@blink1073 blink1073 added the bug label Jul 8, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 88b8c14 into jupyterlab:master Jul 8, 2021
@krassowski krassowski deleted the fix-notebook-navigation branch July 9, 2021 12:30
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:outputarea status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot navigate between cells when focused on output in 3.1.0b1
2 participants