Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the dirty plugin id #10623

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jul 15, 2021

References

Follow-up to #10572

Code changes

Fixes a typo in the dirty plugin id since that plugin was first implemented in retrolab and then here.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 3.1 milestone Jul 15, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@blink1073 blink1073 merged commit 48ee42b into jupyterlab:master Jul 15, 2021
@blink1073
Copy link
Contributor

@meeseeksdev please backport to 3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jul 15, 2021
@jtpio jtpio deleted the typo-dirty-plugin branch July 15, 2021 11:11
blink1073 pushed a commit that referenced this pull request Jul 15, 2021
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants