-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specifying print CSS rules for notebooks #11635
Conversation
Thanks for making a pull request to jupyterlab! |
168da4d
to
b9b2afd
Compare
Diff looks good, thanks! Mind posting a quick screenshot of what it looks like when printed if you have one around? So we have it as reference here in this PR. |
I added a before / after screenshot going over several pages with bqplot figures. |
Nice, thanks! |
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
References
This CSS change is meant to prevent page breaks in the middle of outputs when printing notebooks (webpdf export in nbconvert).
Code changes
Adding
@media print
CSS rules to:display: block
(because flex prevents the use ofbreak-inside
CSS property in inner HTML).break-inside
property toavoid-page
forjp-OutputArea-child
elements.Screenshots (Before | After)