Move notebook logging plugin to notebook-extension package #7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Adding to the 2.0 milestone for consideration, but feel free to bump to 3.0 if there are concerns or reservations. It's not a huge deal, it's just putting plugins where they belong more naturally. |
|
I think this makes sense to get it before the 3.0 RC if you want to rebase |
|
I'll do it right now for the beta, since it is an api-breaking change |
…console-extension.
jasongrout
force-pushed
the
lognotebook
branch
from
0848a57
to
9ca9883
Compare
|
Rebased on master |
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
We had a plugin that logged notebook output. For historical reasons, it was in the logconsole-extension package (basically so that we could introduce the logconsole-extension package into jlab 1.x with backwards compatibility).
It probably makes more sense for this extension to be in the notebook-extension package. One argument for it to stay in the logconsole-extension package is that the log console extension still depends on notebook to do automatic switching between log sources based on the current active notebook. At some point that may (should?) be changed to allow you to select the log source from the log console ux, however.
This isn't a huge deal, so if you don't want to merge it this close to the 2.0 release, that's fine.
User-facing changes
None.
Backwards-incompatible changes
This moves one of the plugins exported by the log console extension to the notebook extension.