Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more linting errors #8454

Merged
merged 11 commits into from
May 21, 2020
Merged

Fix more linting errors #8454

merged 11 commits into from
May 21, 2020

Conversation

jasongrout
Copy link
Contributor

References

Code changes

This fixes a number of linting errors from jlpm run eslint

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 3.0 milestone May 21, 2020
blink1073
blink1073 approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jasongrout
Set __webpack_public_path__ without triggering lint errors.
dd548a3
@jasongrout
Disable the jest/expect-expect lint rule.
b756eba 
We have a number of tests that use our internal test utility functions instead of jest expect statements, so this rule is triggered unnecessarily a lot.
@jasongrout
Update typedoc to 0.17.7
522b225
@jasongrout
Copy link
Contributor Author

@blink1073 - tests pass now!

@blink1073 blink1073 merged commit 71f0737 into jupyterlab:master May 21, 2020
@saulshanabrook saulshanabrook mentioned this pull request Jun 24, 2020
Closed
saulshanabrook added a commit that referenced this pull request Jun 25, 2020
@saulshanabrook
Revert "Merge pull request #8454 from jasongrout/lint-errors"
a572ac3 
71f0737
saulshanabrook added a commit that referenced this pull request Jun 25, 2020
@saulshanabrook
Revert "Merge pull request #8454 from jasongrout/lint-errors"
ae802a8 
71f0737
@jasongrout jasongrout modified the milestones: 3.0, 2.2 Dec 23, 2020
@jasongrout jasongrout mentioned this pull request Dec 23, 2020
Closed
43 tasks
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
pkg:application pkg:apputils pkg:attachments pkg:cells pkg:codeeditor pkg:codemirror pkg:completer pkg:console pkg:coreutils pkg:docmanager pkg:documentsearch pkg:filebrowser pkg:logconsole pkg:markdownviewer pkg:notebook pkg:outputarea pkg:rendermime pkg:services pkg:terminal status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Examples
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jasongrout @blink1073