Add --development and --source-map flags for building extensions. #8961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The development flag implies the source-map flag. Normally, in production mode, source map files are not generated.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
blink1073
approved these changes
Sep 5, 2020
|
Fixed the lint problems. Thanks for the review! |
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #8952
Code changes
By default, we build a lab extension in production mode (and without large source maps).
The development flag implies the source-map flag.
The --source-map flag is there so that you can generate source maps even in production mode, for debugging problems that may appear in production mode, or in case you really want to distribute source map files in your package.
User-facing changes
Backwards-incompatible changes